From d1b02e1f12c221fba34566ee28f7d3c68379113f Mon Sep 17 00:00:00 2001 From: Pradyun Gedam Date: Sat, 18 Sep 2021 10:13:41 +0100 Subject: [PATCH] Drop --build-dir from the CLI This was restored as a no-op for PyCharm, as a way to soften the migration for them. It is no longer necessary, since the migration has completed. --- src/pip/_internal/cli/base_command.py | 14 -------------- src/pip/_internal/cli/cmdoptions.py | 12 ------------ src/pip/_internal/commands/download.py | 1 - src/pip/_internal/commands/install.py | 2 -- src/pip/_internal/commands/wheel.py | 1 - 5 files changed, 30 deletions(-) diff --git a/src/pip/_internal/cli/base_command.py b/src/pip/_internal/cli/base_command.py index 16a8faca82a..abbe4bf888b 100644 --- a/src/pip/_internal/cli/base_command.py +++ b/src/pip/_internal/cli/base_command.py @@ -148,20 +148,6 @@ def _main(self, args: List[str]) -> int: ) options.cache_dir = None - if getattr(options, "build_dir", None): - deprecated( - reason=( - "The -b/--build/--build-dir/--build-directory " - "option is deprecated and has no effect anymore." - ), - replacement=( - "use the TMPDIR/TEMP/TMP environment variable, " - "possibly combined with --no-clean" - ), - gone_in="21.3", - issue=8333, - ) - if "2020-resolver" in options.features_enabled: logger.warning( "--use-feature=2020-resolver no longer has any effect, " diff --git a/src/pip/_internal/cli/cmdoptions.py b/src/pip/_internal/cli/cmdoptions.py index b4f0f83c679..28dfae50a51 100644 --- a/src/pip/_internal/cli/cmdoptions.py +++ b/src/pip/_internal/cli/cmdoptions.py @@ -719,18 +719,6 @@ def _handle_no_cache_dir( help="Don't install package dependencies.", ) -build_dir: Callable[..., Option] = partial( - PipOption, - "-b", - "--build", - "--build-dir", - "--build-directory", - dest="build_dir", - type="path", - metavar="dir", - help=SUPPRESS_HELP, -) - ignore_requires_python: Callable[..., Option] = partial( Option, "--ignore-requires-python", diff --git a/src/pip/_internal/commands/download.py b/src/pip/_internal/commands/download.py index 2f6aac29e83..7de207f1365 100644 --- a/src/pip/_internal/commands/download.py +++ b/src/pip/_internal/commands/download.py @@ -37,7 +37,6 @@ class DownloadCommand(RequirementCommand): def add_options(self) -> None: self.cmd_opts.add_option(cmdoptions.constraints()) self.cmd_opts.add_option(cmdoptions.requirements()) - self.cmd_opts.add_option(cmdoptions.build_dir()) self.cmd_opts.add_option(cmdoptions.no_deps()) self.cmd_opts.add_option(cmdoptions.global_options()) self.cmd_opts.add_option(cmdoptions.no_binary()) diff --git a/src/pip/_internal/commands/install.py b/src/pip/_internal/commands/install.py index a427c6c5929..c5c75542267 100644 --- a/src/pip/_internal/commands/install.py +++ b/src/pip/_internal/commands/install.py @@ -135,8 +135,6 @@ def add_options(self) -> None: ), ) - self.cmd_opts.add_option(cmdoptions.build_dir()) - self.cmd_opts.add_option(cmdoptions.src()) self.cmd_opts.add_option( diff --git a/src/pip/_internal/commands/wheel.py b/src/pip/_internal/commands/wheel.py index 1fb5007a705..cea81ee5195 100644 --- a/src/pip/_internal/commands/wheel.py +++ b/src/pip/_internal/commands/wheel.py @@ -65,7 +65,6 @@ def add_options(self) -> None: self.cmd_opts.add_option(cmdoptions.src()) self.cmd_opts.add_option(cmdoptions.ignore_requires_python()) self.cmd_opts.add_option(cmdoptions.no_deps()) - self.cmd_opts.add_option(cmdoptions.build_dir()) self.cmd_opts.add_option(cmdoptions.progress_bar()) self.cmd_opts.add_option(