Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #10001

Merged
merged 3 commits into from
Jun 3, 2021
Merged

Fix typos #10001

merged 3 commits into from
Jun 3, 2021

Conversation

striezel
Copy link
Contributor

A trivial change that just fixes some typos.

striezel added 2 commits May 19, 2021 22:05
This is required according to the contribution guidelines of pip.
@striezel
Copy link
Contributor Author

Despite adding an empty file to the news/ directory to mark the changes as trivial (as described here), the news file check fails. Is there something I missed?

@hugovk
Copy link
Contributor

hugovk commented May 20, 2021

Despite adding an empty file to the news/ directory to mark the changes as trivial (as described here), the news file check fails. Is there something I missed?

Nope, same happened to me, there's probably something up with the browntruck bot: #9277 (comment)

@striezel
Copy link
Contributor Author

Despite adding an empty file to the news/ directory to mark the changes as trivial (as described here), the news file check fails. Is there something I missed?

Nope, same happened to me, there's probably something up with the browntruck bot: #9277 (comment)

Ah, I see.

@pradyunsg or anyone else who can review PRs: Seeing that the bot is broken, what is the proper way forward for this PR? Can it be merged despite the failed news-file/pr check? Should the empty news entry be removed? Does someone have to label this PR as trivial? Please let me know if there is something I can do to help here.

@pfmoore
Copy link
Member

pfmoore commented May 29, 2021

I think you can just add some content to the .trivial.rst file.

@striezel
Copy link
Contributor Author

striezel commented Jun 1, 2021

I think you can just add some content to the .trivial.rst file.

Done. Let's see whether this helps.

Edit: @pfmoore Thanks, the check succeeded. 👍 So it helped, despite the documentation stating that news files for trivial changes should be empty.

@hugovk
Copy link
Contributor

hugovk commented Jun 1, 2021

I think you can just add some content to the .trivial.rst file.

Thanks, confirmed in #9277 as well.

@xavfernandez xavfernandez merged commit b8e7a70 into pypa:main Jun 3, 2021
@xavfernandez
Copy link
Member

Thanks 👍

@striezel striezel deleted the fix-typos branch June 3, 2021 21:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants