Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning for user when Windows default Path Limit is exceeded #10046

Merged
merged 14 commits into from
Jun 11, 2021
Merged

Warning for user when Windows default Path Limit is exceeded #10046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9cbe7f6
Warning for user when Windows path limit is exceeded
OBITORASU Jun 8, 2021
7204b92
add news entry for issue 10045
OBITORASU Jun 8, 2021
5c73594
change message to error
OBITORASU Jun 8, 2021
e22799b
update padding around default limit
OBITORASU Jun 8, 2021
fe4ab16
add reference link and extra checks
OBITORASU Jun 8, 2021
4dbf953
fix lint issue in docs
OBITORASU Jun 8, 2021
5e2c0cc
add check to verify error.filename is not none
OBITORASU Jun 8, 2021
4593007
use error.filename instead of error
OBITORASU Jun 8, 2021
67dcdf5
use error.filename, remove padding and shorten url
OBITORASU Jun 8, 2021
560d2e9
move the check to create_os_error_message
OBITORASU Jun 8, 2021
1458166
fix the wordings
OBITORASU Jun 8, 2021
9ba78c9
change wordings for the info message
OBITORASU Jun 9, 2021
9f0338a
fix typo
OBITORASU Jun 11, 2021
7a64c94
minor rephrasing of message
OBITORASU Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/10045.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added a warning message for errors caused due to Long Paths being disabled on Windows.
13 changes: 13 additions & 0 deletions src/pip/_internal/commands/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
from pip._internal.req import install_given_reqs
from pip._internal.req.req_install import InstallRequirement
from pip._internal.req.req_tracker import get_requirement_tracker
from pip._internal.utils.compat import WINDOWS
from pip._internal.utils.distutils_args import parse_distutils_args
from pip._internal.utils.filesystem import test_writable_dir
from pip._internal.utils.misc import (
Expand Down Expand Up @@ -737,4 +738,16 @@ def create_os_error_message(error, show_traceback, using_user_site):
parts.append(permissions_part)
parts.append(".\n")

# Suggest the user to enable Long Paths if path length is
# more than 260
if (WINDOWS and error.errno == errno.ENOENT and error.filename and
len(error.filename) > 260):
parts.append(
"HINT: This error might have occurred since "
"this system does not have Windows Long Path "
"support enabled. You can find information on "
"how to enable this at "
"https://pip.pypa.io/warnings/enable-long-paths\n"
)

return "".join(parts).strip() + "\n"