Detect an unnamed requirement is user-specified #10084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
approved these changes
Jun 20, 2021
This always prepares each explicit requirements when the resolver is run, instead of when they are being resolved. But we always want to prepare them anyway (an explicit requirement has only one candidate, so it's either do or die), so this is not really a problem.
uranusjr
force-pushed
the
new-resolver-local-dependencies
branch
from
ffbf0e8 to
73edd74
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9204. See comments in linked issue for diagnosis. I also took the chance to refactor this initial collection logic into the factory since it seems to fit there better.