Don't crash on invalid requirements in installed packages

[takluyver]

See #5839. This adds exception handling in two places:

1. Inside the checking code, so that an error message can be logged which describes the package name - the tracebacks at the moment don't make it clear which package has the problem.
2. Where the pip install machinery calls into the check machinery, because I believe that an uncaught error in checking shouldn't be able to crash the install process.

[benoit-pierre]

What's the return code of pip check if that happen?

[takluyver]

Whatever it would be if that package wasn't there - it will check the other packages as normal.

I guess pip check should exit with code 1 if there's a problem parsing requirements?

[benoit-pierre]

I think yes.

[takluyver]

OK, pip check should now exit with code 1 if such a warning is printed. pip install will print the warning but it won't affect the exit code.

[xavfernandez]

Any chance we could get a test with it ? :)

[takluyver]

I added a test; I'm not working on this further at the moment.

[xavfernandez]

Thanks for the test :)

[benoit-pierre]

@xavfernandez: it might be better holding-off merging things until Github is fully operational again, see https://status.github.com/messages.

[xavfernandez]

I'm optimistic ;)

[jakirkham]

Would it be possible to get a release with this fix?

[pfmoore]

The next release is scheduled for January - see https://pip.pypa.io/en/latest/development/release-process/#release-cadence

[jakirkham]

Would it be reasonable to make a small patch release that contains a backport of this change?

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.