Move some PackageFinder methods (preparation for PR #6910) #6913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjerdonek
added
type: refactor
cjerdonek
force-pushed
the
link-collector-1
branch
from
e24e026 to
ab84bc0
Compare
This moves the methods to before the method where they are called.
cjerdonek
force-pushed
the
link-collector-1
branch
from
ab84bc0 to
5e80b82
Compare
pradyunsg
approved these changes
Aug 24, 2019
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preliminary refactoring PR for PR #6910. It is to make that PR smaller and easier to review.
The current PR does the following three things:
PackageFindermethods with no change to the code.PackageFinder. _sort_locations()from a static method to agroup_locations()function (no code change, but with an improved docstring).test_finder.pywith amake_no_network_finder()helper function.