Skip to content

Include subdirectory URL fragments in cache keys #7335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 15, 2019
Merged

Include subdirectory URL fragments in cache keys #7335

merged 4 commits into from
Nov 15, 2019

Conversation

@sbidoul
Copy link
Member

@sbidoul sbidoul commented Nov 10, 2019

  • include subdirectory fragments as part of cache keys
  • filter on wheel name in addition to tags when selecting wheels from cache, as a safety net in case wheels for different distributions end up in the same cache directory

Fixes #7333

@sbidoul sbidoul force-pushed the subdirectory-cache-key-sbi branch from 169e2e4 to dcd7949 Compare November 10, 2019 20:47
@sbidoul sbidoul mentioned this pull request Nov 10, 2019
Closed
@sbidoul sbidoul force-pushed the subdirectory-cache-key-sbi branch 2 times, most recently from 2553b05 to f6255fe Compare November 10, 2019 21:25
@sbidoul sbidoul force-pushed the subdirectory-cache-key-sbi branch from f6255fe to 613cc01 Compare November 12, 2019 07:50
@sbidoul
Copy link
Member Author

sbidoul commented Nov 12, 2019

The RTD failure seems unrelated. The line where it fails (from pip._internal.index import PackageFinder) does not exist anymore.

@pradyunsg
Copy link
Member

pradyunsg commented Nov 12, 2019

The line where it fails (from pip._internal.index import PackageFinder) does not exist anymore.

Yea, we're discussing with the RTD folks -- pip's participating in a beta for PR previews of documentation being built on ReadTheDocs (well, I had expected it to go a lot smoother but I forgot that pip hits every edge case on platforms like this).

xavfernandez
xavfernandez reviewed Nov 12, 2019
View reviewed changes
xavfernandez
xavfernandez requested changes Nov 13, 2019
View reviewed changes
chrahunt
chrahunt suggested changes Nov 13, 2019
View reviewed changes
@sbidoul sbidoul force-pushed the subdirectory-cache-key-sbi branch from 78463d2 to 47ae034 Compare November 13, 2019 14:40
@sbidoul sbidoul mentioned this pull request Nov 15, 2019
Merged
@xavfernandez xavfernandez merged commit 9e1b1c7 into pypa:master Nov 15, 2019
@xavfernandez
Copy link
Member

xavfernandez commented Nov 15, 2019

Thanks again for a nice PR 👍

@sbidoul sbidoul deleted the subdirectory-cache-key-sbi branch November 16, 2019 10:18
@sbidoul
Copy link
Member Author

sbidoul commented Nov 16, 2019

Thanks again for great reviews

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Dec 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xavfernandez xavfernandez xavfernandez requested changes

+1 more reviewer

@chrahunt chrahunt chrahunt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-locked Outdated issues that have been locked by automation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wheel cache ignores subdirectory URL fragment

4 participants

@sbidoul @pradyunsg @xavfernandez @chrahunt