-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installing from git is broken #5913
Comments
ok, i checked your code, and i guess i got it. Had to add branch via @ in the url. |
Actually, i see that subdirectory is not correctly extracted from the provided url. Your code is expecting it to be provided from another source. |
|
I'm getting this
|
How to specify that in the Pipfile? |
There are a few things going on, but the one that blocks me from getting further is I also cannot install it using pip:
Even if I have torch installed, I get this error -- probably because of the nature of build isolation isn't pulling from the site-packages when building the egg_info. |
You are missing pytorch package |
As I said, I had installed torch right before that -- I believe the building of |
Yes, i was able to install it, by removing that hash part from url. |
Do you mean the subdirectory fragment? If so, then you are technically not installing the same package, from what I can tell the parent setup.py excludes things in csrc directory among others. What version of torch are you using? I have |
can confirm the issue, I'm using subdirectory in
exception:
|
@strufkin the sub-directory issue was fixed in 2023.9.1 so your issue is probably different and related to the ast parsing of the setup.py to determine package name. Without more details in new report for your issue, it will be hard to help, but there is an open PR that handles the case where the package name is an extrapolated variable but the string is still present in the setup.py |
@matteius Exactly my issue! Thank you for pointing to that PR! |
Worth checking against https://pypi.org/project/pipenv/2023.9.8/ |
I can resolve it, but turns out I won't be able to install it because that repository does not yet support windows.
|
In the above example, |
@Bec-k have you had a chance to try the most recent pipenv version or my suggestions? Unfortunately this dependency both requires CUDA (which I have on my host OS) but doesn't support windows (my host OS) so its quite limiting for me to be able to provide support and I am certain the title of the issue doesn't reflect reality -- in general installing from git is working well. This is perhaps an edge case of that, and we had broke sub directory fragments at one point in August, but that has since been fixed. I am willing to leave this open if we update the title and get some updates on what specifically is still not working, but right now I can't push it any further. |
I believe this was solved -- we can reopen if not. |
Using latest
pipenv v2023.9.1
I have printed
vcs_parts
and its content is:['git+https://github.com/HazyResearch/flash-attention.git#subdirectory=csrc/rotary']
The text was updated successfully, but these errors were encountered: