Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Environment.sys_path without vistir.misc.run #5430

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

oz123
Copy link
Contributor

@oz123 oz123 commented Oct 21, 2022

Instead, we use pipenv.utils.shell.load_path.

oz123 added 2 commits October 21, 2022 12:21
The rational here is that click has a broader user base
then vistir, and *if* bugs are encountered they will fixed
there in a quicker manner.
Use `pipenv.utils.shell.load_path`

instead of using `vistir.misc.run`
@oz123 oz123 force-pushed the remove-usage-of-vistir-run branch from f51ae51 to b504515 Compare October 21, 2022 11:39
@oz123 oz123 requested a review from matteius October 21, 2022 12:26
@oz123 oz123 merged commit 35dc409 into main Oct 24, 2022
@oz123 oz123 deleted the remove-usage-of-vistir-run branch October 24, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants