Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump plette take 2 #6134

Merged
merged 3 commits into from
Apr 27, 2024
Merged

Bump plette take 2 #6134

merged 3 commits into from
Apr 27, 2024

Conversation

oz123
Copy link
Contributor

@oz123 oz123 commented Apr 21, 2024

This PR bumps plette to a newer version with better data validation.
Older versions of plette depended on an external library to validate the
format of Pipefile (which is still unfortunately, underdocumented).
I hope to improve this situation by adding more and more validations
to plette after this gets merged.

Note: this plette version is still not yet released. The PRs purpose is to demonstrate
that pipenv actually works with those proposed changes for plette as in this
PR: sarugaku/plette#57

@oz123
Copy link
Contributor Author

oz123 commented Apr 25, 2024

@matteius the usual test failed once again in Python3.12, but this has got nothing to do with plette.
FAILED tests/integration/test_cli.py::test_pipenv_graph_reverse

@oz123 oz123 mentioned this pull request Apr 25, 2024
2 tasks
Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
@matteius matteius merged commit b085b68 into main Apr 27, 2024
14 of 19 checks passed
@matteius matteius deleted the bump-plette-take-2 branch April 27, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants