Skip to content

Commit

Permalink
Better description of what we want
Browse files Browse the repository at this point in the history
  • Loading branch information
uranusjr committed Feb 9, 2021
1 parent 3162d2c commit cebdc53
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/pipx/venv.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@

logger = logging.getLogger(__name__)

# This regex was only introduced into importlib.metadata in Python 3.9.
_entry_point_value_pattern = re.compile(
r"""
^(?P<module>[\w.]+)\s*
Expand Down Expand Up @@ -361,6 +360,8 @@ def run_app(self, app: str, filename: str, app_args: List[str]) -> NoReturn:
exec_app([str(self.bin_path / filename)] + app_args)

# Evaluate and execute the entry point.
# TODO: After dropping support for Python < 3.9, use
# "entry_point.module" and "entry_point.attr" instead.
match = _entry_point_value_pattern.match(entry_point.value)
assert match is not None, "invalid entry point"
module, attr = match.group("module", "attr")
Expand Down

0 comments on commit cebdc53

Please sign in to comment.