-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add better handling for 'app not found' #733
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a test plus changelog, plus what the other reviewer requested.
@gaborbernat I wasn't able to get most of the tests to pass on my machine even on master branch, so I can't reliably add a test here. Plus, I'm not entirely how to test this fix as well. |
I can, however, provide a pretty good example of what was broken and is now fixed: $ pipx run textflip hello
'textflip' executable script not found in package 'textflip'. Available
executable scripts: flip
$ . venv/bin/activate
$ pipx run textflip hello
oןןǝɥ
$ pipx run --spec=textflip something hi
'something' executable script not found in package 'textflip'.
Available executable scripts:
flip - usage: 'pipx run --spec textflip flip [arguments?]' As for a package that has multiple runnable apps but neither of them matching the name of the package, I could find no examples sadly. |
ba1004d
to
9f9271b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix merge conflicts and run tests again.
docs/changelog.md
Summary of changes
Added one feature:
Improved the error message thrown when the package is not a runnable app, to include the command required to run the app.
Resolves #725