From 1926fb2f276b4b4d9788acc9a855b024caf92ab5 Mon Sep 17 00:00:00 2001 From: layday Date: Tue, 27 Feb 2024 21:29:09 +0200 Subject: [PATCH 1/2] Export `SubprocessRunner` mypy in strict mode will complain that `SubprocessRunner` is not defined if it is not explicitly exported. --- src/pyproject_hooks/__init__.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/pyproject_hooks/__init__.py b/src/pyproject_hooks/__init__.py index 99f11d6..fd03d6d 100644 --- a/src/pyproject_hooks/__init__.py +++ b/src/pyproject_hooks/__init__.py @@ -12,6 +12,10 @@ quiet_subprocess_runner, ) +if TYPE_CHECKING: + from ._impl import SubprocessRunner + + __version__ = "1.0.0" __all__ = [ "BackendUnavailable", @@ -20,7 +24,5 @@ "default_subprocess_runner", "quiet_subprocess_runner", "BuildBackendHookCaller", + "SubprocessRunner", ] - -if TYPE_CHECKING: - from ._impl import SubprocessRunner # noqa: F401 From 773b0635b6a13ca2b62a50eedec5cd31bd6f6b32 Mon Sep 17 00:00:00 2001 From: layday Date: Sat, 2 Mar 2024 14:32:00 +0200 Subject: [PATCH 2/2] Fix star import --- src/pyproject_hooks/__init__.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/pyproject_hooks/__init__.py b/src/pyproject_hooks/__init__.py index fd03d6d..eba2275 100644 --- a/src/pyproject_hooks/__init__.py +++ b/src/pyproject_hooks/__init__.py @@ -12,10 +12,6 @@ quiet_subprocess_runner, ) -if TYPE_CHECKING: - from ._impl import SubprocessRunner - - __version__ = "1.0.0" __all__ = [ "BackendUnavailable", @@ -24,5 +20,9 @@ "default_subprocess_runner", "quiet_subprocess_runner", "BuildBackendHookCaller", - "SubprocessRunner", ] + +if TYPE_CHECKING: + from ._impl import SubprocessRunner + + __all__ += ["SubprocessRunner"]