Skip to content

Conversation

@Avasam
Copy link
Contributor

@Avasam Avasam commented Mar 16, 2024

Summary of changes

This was my original idea, but in #4257 (comment), @abravalheri mentioned that:

[...] I think we just remove the testing-integration and use testing everywhere...

Although it might add a bit of overhead for the integration tests, it will simplify and streamline the setup... This way we reduce the divergence with skeleton. The additional overhead in the integration tests should not be too much, and the integration tests just run before the releases anyway.

But I'm still opening this PR as an option / for comparison.

Accepting this closes #4282

Pull Request Checklist

  • Changes have tests (these are test changes)
  • News fragment added in newsfragments/. (no user facing changes)
    (See documentation for details)

@Avasam Avasam marked this pull request as ready for review March 16, 2024 16:27
@Avasam Avasam deleted the deduplicate-testing-dependencies-by-referencing-testing-integration branch April 16, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant