Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handling of direct URL specifiers in requirements #250

Merged
merged 2 commits into from
Sep 23, 2018

Conversation

benoit-pierre
Copy link
Member

Do not strip the URLs. Fix #249.

@codecov
Copy link

codecov bot commented Aug 28, 2018

Codecov Report

Merging #250 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
+ Coverage   59.31%   59.41%   +0.09%     
==========================================
  Files          12       12              
  Lines         816      818       +2     
==========================================
+ Hits          484      486       +2     
  Misses        332      332
Impacted Files Coverage Δ
wheel/metadata.py 97.4% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f385549...3a13f00. Read the comment docs.

@cam72cam
Copy link

cam72cam commented Sep 6, 2018

I can confirm that this works in relation to pypa/pip#5768

@pradyunsg
Copy link
Member

pradyunsg commented Sep 22, 2018

The PEP changes are accepted, so merging this should be acceptable now IMO. I'll be opening a PR making changes to the user guide's Specifications to convey the same details soon.

/cc @pypa/wheel-committers

@agronholm agronholm merged commit fbb5ae7 into pypa:master Sep 23, 2018
@agronholm
Copy link
Contributor

Thanks, and sorry for taking so long.

@pradyunsg
Copy link
Member

Thanks for this @agronholm! :)

Any ideas when this would make it into a release?

@agronholm
Copy link
Contributor

I plan to make a release this week, after I've dealt with the pending PRs. There's a good deal of new stuff that needs to be in the release version. I just hoped I could do a v1.0 next but I'm still not confident about that. Thus I will make another 0.X release.

@cam72cam
Copy link

Just a note to anyone finding this thread and still having issues with PEP508, pypa/pip#5780 is related and required for upgrading these sorts of packages using pip.

@benoit-pierre benoit-pierre deleted the fix_req_with_url_spec branch September 24, 2018 18:31
@benoit-pierre benoit-pierre mentioned this pull request Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants