Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for hostnames in the /etc/config/dhcp file as well #30

Open
Kiougar opened this issue Dec 12, 2017 · 0 comments
Open

Search for hostnames in the /etc/config/dhcp file as well #30

Kiougar opened this issue Dec 12, 2017 · 0 comments

Comments

@Kiougar
Copy link
Contributor

Kiougar commented Dec 12, 2017

Hey @pyrovski it's me again!

I think it would be great if wrtbwmon could also parse the /etc/config/dhcp file to search for hostnames.
The great thing about this file is that when the user assigns a static IP from the DHCP settings in his router the following entry appears in the file:

config host
	option name 'BradleyDesktop'
	option dns '1'
	option mac '1c:1b:0d:e5:60:f1'
	option ip '192.168.1.69'
	option leasetime 'infinite'

also, when the user sets a custom hostname from the Hostnames page the following entry appears:

config domain
	option name 'TestDeviceName'
	option ip '192.168.1.167'

What do you think? Is this PR worthy?


You can read the whole discussion that led to this solution in Kiougar/luci-wrtbwmon#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant