Adds support to python 3.13 #466
Conversation
.github/workflows/test.yml
Outdated
| @@ -63,6 +63,7 @@ jobs: | |||
| uses: actions/setup-python@v5 | |||
| with: | |||
| python-version: ${{ matrix.python }} | |||
| allow-prereleases: true | |||
There was a problem hiding this comment.
Is this needed? Python 3.13 should not be a prerelease anymore?
There was a problem hiding this comment.
@The-Compiler to Python 3.13 no, Github already release the final version, but it could be useful if we want to prepare the ci/code to next version!
In the manifest 3.14 is now available https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json.
Do you think it's better to take it off?
There was a problem hiding this comment.
I think it is published now, so we can take it off? I'm doing it to see.
Seems to be broken at the moment: ``` Run actions/attest-build-provenance@v1 Run actions/attest-build-provenance@f1185f1 Error: Failed to get ID token: Error message: Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable ```
| @@ -25,7 +25,8 @@ jobs: | |||
| - name: Build and Check Package | |||
| uses: hynek/build-and-inspect-python-package@v2.9.0 | |||
| with: | |||
| attest-build-provenance-github: 'true' | |||
| # Disabling because this is failing currently, see #466. | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
To summarize, it is better then to use with attestations in the publish-pypi action instead of in hynek/build-and-inspect-python-package?
There was a problem hiding this comment.
Yeah, that's my stance. Though, not everybody feels that way.
FWIW, GitHub's own attestations are embedded into the UI. The PyPI ones are upload provenance, not necessarily build provenance, technically.
No description provided.