Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support to python 3.13 #466

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Adds support to python 3.13 #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4e9ba3
Adds support to python 3.13
jairhenrique Oct 13, 2024
23f2801
Update test.yml
nicoddemus Oct 25, 2024
7208869
Disable 'attest-build-provenance-github'
nicoddemus Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ jobs:
- name: Build and Check Package
uses: hynek/build-and-inspect-python-package@v2.9.0
with:
attest-build-provenance-github: 'true'
# Disabling because this is failing currently, see #466.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicoddemus hynek/build-and-inspect-python-package#105 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To summarize, it is better then to use with attestations in the publish-pypi action instead of in hynek/build-and-inspect-python-package?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's my stance. Though, not everybody feels that way.

FWIW, GitHub's own attestations are embedded into the UI. The PyPI ones are upload provenance, not necessarily build provenance, technically.

attest-build-provenance-github: 'false'

test:

Expand All @@ -36,7 +37,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
os: [ubuntu-latest, windows-latest]
tox_env: ["py"]
include:
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ classifiers = [
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Topic :: Software Development :: Testing",
]

Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
minversion = 3.5.3
envlist = py{38,39,310,311,312}, norewrite, pytest6
envlist = py{38,39,310,311,312,313}, norewrite, pytest6

[testenv]
deps =
Expand Down