Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Service.exists #741

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Add Service.exists #741

merged 1 commit into from
Nov 13, 2023

Conversation

CarstenGrohmann
Copy link
Contributor

No description provided.

@philpep philpep added the enhancement This issue/PR relates to a feature request. label Nov 13, 2023
philpep
philpep approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@philpep philpep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, probably easy and worth to add a test for this, can be done as a followup PR.

@philpep philpep merged commit 76170a4 into pytest-dev:main Nov 13, 2023
7 checks passed
@CarstenGrohmann CarstenGrohmann deleted the add_SystemdService_exists branch November 14, 2023 07:42
@CarstenGrohmann
Copy link
Contributor Author

#754 created to address this suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philpep philpep philpep approved these changes

Assignees
No one assigned
Labels
enhancement This issue/PR relates to a feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarstenGrohmann @philpep