Fix issue where a new line was always written for the live log finish section #3194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
requested changes
Feb 8, 2018
_pytest/logging.py
Outdated
| self.stream.write('\n') | ||
| self._first_record_emitted = True | ||
| elif self._when in ('teardown', 'finish'): | ||
| if self._test_outcome_written is False: |
There was a problem hiding this comment.
It is considered more Pythonic to write if not self._test_outcome_written instead.
There was a problem hiding this comment.
But less explicit. Personal habits...
I'll change.
testing/logging/test_reporting.py
Outdated
| @@ -293,6 +294,62 @@ def test_log_2(fix): | |||
| ]) | |||
|
|
|||
|
|
|||
| def test_sections_single_new_line_after_test_outcome(testdir, request): | |||
| """Check that with live logging enable we are printing the correct headers during | |||
There was a problem hiding this comment.
It seems this docstring is not related to the test
s0undt3ch
force-pushed
the
feature/logstart-logfinish
branch
from
aa70cc4 to
0f4092e
Compare
|
Updated. |
s0undt3ch
force-pushed
the
feature/logstart-logfinish
branch
from
0f4092e to
6491833
Compare
|
I tested out the branch and it works as advertised. 👍 Thanks a lot @s0undt3ch! |
nicoddemus
approved these changes
Feb 8, 2018
s0undt3ch
force-pushed
the
feature/logstart-logfinish
branch
from
6491833 to
d776e56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the feature PR #3189 where we'd always get 2 new lines between each log message on the finish section.
featuresbranch for new features and removals/deprecations.