Revert change of Callinfo.result default value #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in pytest-dev#3560, this should not go to master because this breaks the API. Reverts commits: 1a7dcd7 198e993
|
@alanbato my bad for now realizing this before. Thanks @RonnyPfannschmidt for catching my slip up! |
|
Failure is unrelated: #3564 |
RonnyPfannschmidt
approved these changes
Jun 11, 2018
|
sorry i forgot about this one - i couldn't merge on the phone |
nicoddemus
added a commit
that referenced
this pull request
Jun 12, 2018
This entry was removed in #3562
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Nov 13, 2018
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Nov 13, 2018
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #3560, this should not go to master because this breaks
the API.
Reverts commits:
1a7dcd7
198e993
Follow up of #3560 (review)