Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace broken type annotations with type comments #3684

Merged
merged 1 commit into from
Jul 15, 2018
Merged

Replace broken type annotations with type comments #3684

merged 1 commit into from
Jul 15, 2018

Conversation

Vlad-Shcherbina
Copy link
Contributor

Fixes #3635.


Checklist:

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Target the master branch for bug fixes, documentation updates and trivial changes.
  • Target the features branch for new features and removals/deprecations.
  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS in alphabetical order;

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 92.655% when pulling 58e77f5 on Vlad-Shcherbina:type_comments into 0565a7a on pytest-dev:master.

@nicoddemus nicoddemus merged commit 771d3e8 into pytest-dev:master Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_type_hints() fails on Mark.__init__
3 participants