Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.6] Fix verbosity bug in --collect-only (backport of #5391) #5411

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

nicoddemus
Copy link
Member

No description provided.

Fix verbosity bug in --collect-only
@nicoddemus nicoddemus changed the title [4.6] Fix verbosity bug in --collect-only (#5391) [4.6] Fix verbosity bug in --collect-only (backport of #5391) Jun 6, 2019
@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #5411 into 4.6-maintenance will increase coverage by 0.23%.
The diff coverage is 94.44%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           4.6-maintenance    #5411      +/-   ##
===================================================
+ Coverage            95.55%   95.79%   +0.23%     
===================================================
  Files                  115      115              
  Lines                26391    26407      +16     
  Branches              2605     2609       +4     
===================================================
+ Hits                 25219    25297      +78     
+ Misses                 831      805      -26     
+ Partials               341      305      -36
Impacted Files Coverage Δ
src/_pytest/logging.py 96% <100%> (+0.03%) ⬆️
testing/logging/test_reporting.py 99.66% <92.3%> (-0.34%) ⬇️
testing/test_argcomplete.py 20.28% <0%> (-47.83%) ⬇️
src/_pytest/_argcomplete.py 35.13% <0%> (-40.55%) ⬇️
src/_pytest/pytester.py 86.44% <0%> (-3.39%) ⬇️
testing/test_assertrewrite.py 82.6% <0%> (-1.47%) ⬇️
src/_pytest/unittest.py 93.22% <0%> (-1.05%) ⬇️
src/_pytest/terminal.py 93.02% <0%> (-0.42%) ⬇️
src/_pytest/fixtures.py 97.55% <0%> (+0.27%) ⬆️
testing/test_capture.py 99.25% <0%> (+0.29%) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cae76b...a93c50c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #5411 into 4.6-maintenance will increase coverage by 0.23%.
The diff coverage is 94.44%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           4.6-maintenance    #5411      +/-   ##
===================================================
+ Coverage            95.55%   95.79%   +0.23%     
===================================================
  Files                  115      115              
  Lines                26391    26407      +16     
  Branches              2605     2609       +4     
===================================================
+ Hits                 25219    25297      +78     
+ Misses                 831      805      -26     
+ Partials               341      305      -36
Impacted Files Coverage Δ
src/_pytest/logging.py 96% <100%> (+0.03%) ⬆️
testing/logging/test_reporting.py 99.66% <92.3%> (-0.34%) ⬇️
testing/test_argcomplete.py 20.28% <0%> (-47.83%) ⬇️
src/_pytest/_argcomplete.py 35.13% <0%> (-40.55%) ⬇️
src/_pytest/pytester.py 86.44% <0%> (-3.39%) ⬇️
testing/test_assertrewrite.py 82.6% <0%> (-1.47%) ⬇️
src/_pytest/unittest.py 93.22% <0%> (-1.05%) ⬇️
src/_pytest/terminal.py 93.02% <0%> (-0.42%) ⬇️
src/_pytest/fixtures.py 97.55% <0%> (+0.27%) ⬆️
testing/test_capture.py 99.25% <0%> (+0.29%) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cae76b...a93c50c. Read the comment docs.

@asottile asottile merged commit 355954d into pytest-dev:4.6-maintenance Jun 6, 2019
@nicoddemus nicoddemus deleted the backport-5391 branch June 6, 2019 01:23
@nicoddemus
Copy link
Member Author

nicoddemus commented Jun 6, 2019

How about if those who merge a backport PR also apply the "backported" label on the original PR, as it is easier for them. What do you guys think?

@asottile
Copy link
Member

asottile commented Jun 6, 2019

oh yeah good call, my bad

@nicoddemus
Copy link
Member Author

No worries at all, just realized that and thought I would mention it. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants