Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backends: Move Facebook Limited Login to separate module #778

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

nijel
Copy link
Member

@nijel nijel commented Mar 27, 2023

Proposed changes

This removes jose dependency from Facebook backend.

Fixes #773

Types of changes

Please check the type of change your PR introduces:

  • Release (new release request)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Other information

Any other information that is important to this PR such as screenshots of how
the component looks before and after the change.

@nijel nijel requested a review from a team March 27, 2023 10:57
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #778 (59eb5e9) into master (d1d91ae) will increase coverage by 0.00%.
The diff coverage is 64.00%.

❗ Current head 59eb5e9 differs from pull request most recent head 10cc300. Consider uploading reports for the commit 10cc300 to get more accurate results

@@           Coverage Diff           @@
##           master     #778   +/-   ##
=======================================
  Coverage   77.34%   77.34%           
=======================================
  Files         325      326    +1     
  Lines        9864     9865    +1     
  Branches     1174     1174           
=======================================
+ Hits         7629     7630    +1     
  Misses       2084     2084           
  Partials      151      151           
Flag Coverage Δ
unittests 77.34% <64.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
social_core/backends/facebook.py 54.13% <ø> (-1.00%) ⬇️
social_core/backends/facebook_limited.py 62.50% <62.50%> (ø)
social_core/tests/backends/test_facebook.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AuthTokenError imported but unused, see failed CI jobs. Otherwise looks good to me.

This removes jose dependency from Facebook backend.

Fixes python-social-auth#773
@nijel
Copy link
Member Author

nijel commented Mar 27, 2023

Somehow I didn't have enabled pre-commit locally, pushed with the fixes now…

@nijel nijel mentioned this pull request Mar 27, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'jose'
2 participants