Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 🤖 automerge #103739

Closed
arhadthedev opened this issue Apr 24, 2023 · 4 comments
Closed

Remove 🤖 automerge #103739

arhadthedev opened this issue Apr 24, 2023 · 4 comments
Labels
type-feature A feature request or enhancement

Comments

@arhadthedev
Copy link
Member

arhadthedev commented Apr 24, 2023

According to python/core-workflow#498 (comment), the following steps must be done:

  1. CI: Do not allow merge if labelled DO-NOT-MERGE #103337
  2. Enable "Allow automerge" repo option on cpython, devguide, peps and core-workflow
  3. Removed "automerge" label devguide#1082, Document the use of GitHub automerge devguide#1079
  4. This PR is here
  5. Remove automerge stuff miss-islington#610

Since step 5 was implemented before step 3 (and, probably, step 2), we cannot postpone removal of the https://github.com/python/cpython/labels/%3Arobot%3A%20automerge. Otherwise, core developers will continue to apply no longer working label.

@arhadthedev arhadthedev added the type-feature A feature request or enhancement label Apr 24, 2023
@arhadthedev arhadthedev changed the title Remove <kbd>🤖 automerge</kbd> Remove 🤖 automerge Apr 24, 2023
@sobolevn
Copy link
Member

сс @ezio-melotti

@hugovk
Copy link
Member

hugovk commented Apr 24, 2023

Since step 5 was implemented before step 3 (and, probably, step 2),

Step 5 was merged on Thursday and step 2 was enabled on Wednesday. Sorry we didn't post about it in the issue.

Anyway, yes, let's remove the label now.

@hugovk
Copy link
Member

hugovk commented Apr 24, 2023

And I have permissions to delete labels, so have deleted it. 🗑️

@hugovk hugovk closed this as completed Apr 24, 2023
@arhadthedev
Copy link
Member Author

For backup purposes: the label looked like this:

Because after I closed the tab, it's gone.

@hugovk hugovk moved this from Todo to Done in CPython labels Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature A feature request or enhancement
Projects
Status: Done
Development

No branches or pull requests

3 participants