-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pathlib.Path.absolute not marked as "new in version 3.11" #99387
Comments
@tudortimi this is a good first issue to contribute. Would you like to do it? If you don't have time, no worries - I can help you. |
@sobolevn I'll give it a try. |
https://github.com/python/cpython/blame/v3.4.0/Lib/pathlib.py#L1002-L1018 A |
Hi, I am new to open source and this will be my first one so I would like to try it |
I have gone through python's helping with documentation, is that enough or is there anything else I need to go through before I start making changes? |
I'm not sure that documenting when a function was first documented makes much sense. Saying "New in version ..." is really saying when the feature first became available (and is typically used only if that feature was added after its module or class was first made available). Even the directive itself is called I recommend we just close this issue. |
@brandtbucher But was the function widely used if it wasn't documented? I for one always used |
Agree with Brandt that closing this issue seems appropriate. Although maybe we could think about backporting #26153 (this would e.g. update the table above in 3.10's docs)? |
Without tests I didn't want to backport the doc changes as I don't know what state the code was i. But I also agree that documenting it as new in 3.11 seems weird, too, since the name has previously existed. I say we just leave the docs alone. |
New methods are generally marked as "new in version X". For example,
pathlib.Path.is_relative_to
is marked as "new in version 3.9" : https://docs.python.org/3/library/pathlib.html#pathlib.PurePath.is_relative_topathlib.Path.absolute
was added in version 3.11, but is not marked as such: https://docs.python.org/3/library/pathlib.html#pathlib.Path.absolutepathlib.Path.absolute()
docs to addversionadded
#99416The text was updated successfully, but these errors were encountered: