Skip to content

Rename redundant enum tests so that they run #102535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hauntsaninja merged 2 commits into from
Mar 14, 2023
Merged

Rename redundant enum tests so that they run #102535

hauntsaninja merged 2 commits into from
Mar 14, 2023

Conversation

@JosephSBoyle
Copy link
Contributor

@JosephSBoyle JosephSBoyle commented Mar 8, 2023

No issue for this, as I believe that it's trivial.

There are three methods named test_doc_1 in this class and since only one will ever be executed we should delete two.
I don't have a particular preference for which but it seems natural to leave the Single Double enum examples.

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Mar 8, 2023
@JosephSBoyle JosephSBoyle changed the title Remove redundant tests which were not being ran Remove redundant tests which were not being run Mar 8, 2023
@JosephSBoyle JosephSBoyle changed the title Remove redundant tests which were not being run Remove redundant tests which are not run Mar 8, 2023
hauntsaninja
hauntsaninja approved these changes Mar 11, 2023
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good spot!

@furkanonder
Copy link
Contributor

furkanonder commented Mar 11, 2023

Good catch!

corona10
corona10 requested changes Mar 14, 2023
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that the change is correct.
Please rename them as the test_doc_3 and test_doc_4 instead of removing them.

@bedevere-bot
Copy link

bedevere-bot commented Mar 14, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@corona10
Copy link
Member

corona10 commented Mar 14, 2023 •
edited
Loading

@hauntsaninja
Oops, I read your comment just after I requested changes.
IMO, It looks like that tests were implemented to be run rather than not run.
So let's keep them even if they look redundant. (removing is easy adding is hard)

@ethanfurman
Copy link
Member

ethanfurman commented Mar 14, 2023

As @corona10 said, let's rename them to 3 and 4 instead of deleting them. Thank you for finding that!

@JosephSBoyle
Copy link
Contributor Author

JosephSBoyle commented Mar 14, 2023 •
edited
Loading

Thanks for the feedback guys:)

Added the tests back and renamed them

For the bot:
I have made the requested changes; please review again

@hauntsaninja hauntsaninja changed the title Remove redundant tests which are not run Rename redundant tests so that they run Mar 14, 2023
@hauntsaninja hauntsaninja added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Mar 14, 2023
@hauntsaninja hauntsaninja changed the title Rename redundant tests so that they run Rename redundant enum tests so that they run Mar 14, 2023
@hauntsaninja hauntsaninja merged commit a028778 into python:main Mar 14, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Mar 14, 2023

Thanks @JosephSBoyle for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Mar 14, 2023

Sorry, @JosephSBoyle and @hauntsaninja, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a028778d4c813914ae1e6ef3a04bb96dbf92ace6 3.10

@bedevere-bot
Copy link

bedevere-bot commented Mar 14, 2023

GH-102704 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 14, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 14, 2023
@JosephSBoyle @miss-islington
Rename redundant enum tests so that they run (pythonGH-102535)
d42cac9 
(cherry picked from commit a028778)

Co-authored-by: JosephSBoyle <48555120+JosephSBoyle@users.noreply.github.com>
@hauntsaninja
Copy link
Contributor

hauntsaninja commented Mar 14, 2023

JosephSBoyle, thanks again!
corona10, no worries! I'd held off on merging the PR in case ethanfurman or anyone else had a different opinion :-)

@hauntsaninja hauntsaninja removed the needs backport to 3.10 only security fixes label Mar 14, 2023
miss-islington added a commit that referenced this pull request Mar 14, 2023
@miss-islington @JosephSBoyle
Rename redundant enum tests so that they run (GH-102535)
1649f3e 
(cherry picked from commit a028778)

Co-authored-by: JosephSBoyle <48555120+JosephSBoyle@users.noreply.github.com>
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@JosephSBoyle @Fidget-Spinner
Rename redundant enum tests so that they run (python#102535)
a504830
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@JosephSBoyle @warsaw
Rename redundant enum tests so that they run (python#102535)
d1a8da5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 requested changes

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@furkanonder furkanonder furkanonder approved these changes

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Assignees

@hauntsaninja hauntsaninja

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@JosephSBoyle @furkanonder @bedevere-bot @corona10 @ethanfurman @miss-islington @hauntsaninja @AlexWaygood