From 51a688f3813f7d9fa78c6a767e6e83ce8def99bb Mon Sep 17 00:00:00 2001 From: Guido van Rossum Date: Wed, 17 May 2023 16:45:11 -0700 Subject: [PATCH] gh-104340: Suppress warning about unawaited exception for closed pipe stdin (GH-104586) (cherry picked from commit 7fc8e2d4627cdba5cb0075c9052ed6f4b6ecd36d) Co-authored-by: Guido van Rossum --- Lib/asyncio/subprocess.py | 3 +++ .../Library/2023-05-17-20-03-01.gh-issue-104340.kp_XmX.rst | 1 + 2 files changed, 4 insertions(+) create mode 100644 Misc/NEWS.d/next/Library/2023-05-17-20-03-01.gh-issue-104340.kp_XmX.rst diff --git a/Lib/asyncio/subprocess.py b/Lib/asyncio/subprocess.py index cd10231f710f11..c380bbb0ee93ec 100644 --- a/Lib/asyncio/subprocess.py +++ b/Lib/asyncio/subprocess.py @@ -81,6 +81,9 @@ def pipe_connection_lost(self, fd, exc): self._stdin_closed.set_result(None) else: self._stdin_closed.set_exception(exc) + # Since calling `wait_closed()` is not mandatory, + # we shouldn't log the traceback if this is not awaited. + self._stdin_closed._log_traceback = False return if fd == 1: reader = self.stdout diff --git a/Misc/NEWS.d/next/Library/2023-05-17-20-03-01.gh-issue-104340.kp_XmX.rst b/Misc/NEWS.d/next/Library/2023-05-17-20-03-01.gh-issue-104340.kp_XmX.rst new file mode 100644 index 00000000000000..5b03622df6a2ab --- /dev/null +++ b/Misc/NEWS.d/next/Library/2023-05-17-20-03-01.gh-issue-104340.kp_XmX.rst @@ -0,0 +1 @@ +When an ``asyncio`` pipe protocol loses its connection due to an error, and the caller doesn't await ``wait_closed()`` on the corresponding ``StreamWriter``, don't log a warning about an exception that was never retrieved. After all, according to the ``StreamWriter.close()`` docs, the ``wait_closed()`` call is optional ("not mandatory").