From f18fd30fdc3e726873f78fd05775387e4c3688c7 Mon Sep 17 00:00:00 2001 From: Donghee Na Date: Sat, 25 Nov 2023 00:34:10 +0900 Subject: [PATCH 1/2] gh-112213: Add missing declartion of target_critical_section --- Tools/clinic/clinic.py | 1 + 1 file changed, 1 insertion(+) diff --git a/Tools/clinic/clinic.py b/Tools/clinic/clinic.py index b1dfcfea92a0d0..1c932a2c011322 100755 --- a/Tools/clinic/clinic.py +++ b/Tools/clinic/clinic.py @@ -5138,6 +5138,7 @@ class DSLParser: parameter_continuation: str preserve_output: bool critical_section: bool + target_critical_section: list[str] from_version_re = re.compile(r'([*/]) +\[from +(.+)\]') def __init__(self, clinic: Clinic) -> None: From 4ccff5cc6e7eaa2a09a40b0d59f17c42eb5b0351 Mon Sep 17 00:00:00 2001 From: Alex Waygood Date: Fri, 24 Nov 2023 15:39:54 +0000 Subject: [PATCH 2/2] fix a few more nits while we're here --- Tools/clinic/clinic.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Tools/clinic/clinic.py b/Tools/clinic/clinic.py index 1c932a2c011322..c0830864175adf 100755 --- a/Tools/clinic/clinic.py +++ b/Tools/clinic/clinic.py @@ -5135,6 +5135,7 @@ class DSLParser: indent: IndentStack kind: FunctionKind coexist: bool + forced_text_signature: str | None parameter_continuation: str preserve_output: bool critical_section: bool @@ -5170,11 +5171,11 @@ def reset(self) -> None: self.indent = IndentStack() self.kind = CALLABLE self.coexist = False - self.forced_text_signature: str | None = None + self.forced_text_signature = None self.parameter_continuation = '' self.preserve_output = False self.critical_section = False - self.target_critical_section: list[str] = [] + self.target_critical_section = [] def directive_version(self, required: str) -> None: global version