Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the PyGetSetDef documentation #116056

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Feb 28, 2024

closure is not a function pointer, it is a user data pointer.

Inspired by #20756.


📚 Documentation preview 📚: https://cpython-previews--116056.org.readthedocs.build/

closure is not a function pointer, it is a user data pointer.
@bedevere-app bedevere-app bot added awaiting core review docs Documentation in the Doc dir labels Feb 28, 2024
@serhiy-storchaka serhiy-storchaka merged commit df59401 into python:main Mar 5, 2024
30 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the PyGetSetDef-closure branch March 5, 2024 15:48
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 5, 2024
closure is not a function pointer, it is a user data pointer.
(cherry picked from commit df59401)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington-app
Copy link

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker df594011089a83d151ac7000954665536f3461b5 3.11

@bedevere-app
Copy link

bedevere-app bot commented Mar 5, 2024

GH-116363 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Mar 5, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 5, 2024
closure is not a function pointer, it is a user data pointer.
(cherry picked from commit df59401)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 5, 2024

GH-116368 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Mar 5, 2024
serhiy-storchaka added a commit that referenced this pull request Mar 5, 2024
closure is not a function pointer, it is a user data pointer.
(cherry picked from commit df59401)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Mar 5, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
closure is not a function pointer, it is a user data pointer.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
closure is not a function pointer, it is a user data pointer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant