Kenjin tier2 inliner redux #116394
Closed
Kenjin tier2 inliner redux #116394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on into tier2_inliner_redux
gvanrossum
commented
Mar 6, 2024
Python/ceval.c
Outdated
Comment on lines
1678
to
1681
| // Make sure that this is, indeed, the top frame. We can't check this in | ||
| // _PyThreadState_PopFrame, since f_code is already cleared at that point: | ||
| assert((PyObject **)frame + _PyFrame_GetCode(frame)->co_framesize == | ||
| tstate->datastack_top); | ||
| // // Make sure that this is, indeed, the top frame. We can't check this in | ||
| // // _PyThreadState_PopFrame, since f_code is already cleared at that point: | ||
| // assert((PyObject **)frame + _PyFrame_GetCode(frame)->co_framesize == | ||
| // tstate->datastack_top); |
There was a problem hiding this comment.
Obviously this block should just be deleted. I'm leaving it in because it seems a kind of important check, but I don't know how to reproduce it now that datastack_top may be larger than the end of the reserved stack space due to call inlining.
gvanrossum
force-pushed
the
kenjin_tier2_inliner_redux
branch
from
6c63c21 to
dad9100
Compare
gvanrossum
force-pushed
the
kenjin_tier2_inliner_redux
branch
from
396223a to
2f9539b
Compare
|
@Fidget-Spinner Could you merge this in your PR's branch? |
|
Closing,nNow that this is merged into gh-116290. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like Fidget-Spinner#72 but without main merge.