From dfb839b983ab3280c03fbfedd38966fb98756204 Mon Sep 17 00:00:00 2001 From: Soumendra Ganguly Date: Fri, 27 Nov 2020 15:39:59 -0600 Subject: [PATCH 1/2] test_master_read() in test_pty.py should be expected to fail on every platform that is not Linux; that includes Solaris. Signed-off-by: Soumendra Ganguly --- Lib/test/test_pty.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Lib/test/test_pty.py b/Lib/test/test_pty.py index a45be284a95440..3114b868682b36 100644 --- a/Lib/test/test_pty.py +++ b/Lib/test/test_pty.py @@ -82,9 +82,8 @@ def expectedFailureIfStdinIsTTY(fun): pass return fun -def expectedFailureOnBSD(fun): - PLATFORM = platform.system() - if PLATFORM.endswith("BSD") or PLATFORM == "Darwin": +def expectedFailureIfNotLinux(fun): + if platform.system() != "Linux": return unittest.expectedFailure(fun) return fun @@ -314,7 +313,7 @@ def test_fork(self): os.close(master_fd) - @expectedFailureOnBSD + @expectedFailureIfNotLinux def test_master_read(self): debug("Calling pty.openpty()") master_fd, slave_fd = pty.openpty() From bc676f61578cdd785c26612acbe9c7afb3127b33 Mon Sep 17 00:00:00 2001 From: "blurb-it[bot]" <43283697+blurb-it[bot]@users.noreply.github.com> Date: Fri, 27 Nov 2020 21:46:55 +0000 Subject: [PATCH 2/2] =?UTF-8?q?=F0=9F=93=9C=F0=9F=A4=96=20Added=20by=20blu?= =?UTF-8?q?rb=5Fit.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../NEWS.d/next/Library/2020-11-27-21-46-54.bpo-41818.IXmYhQ.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 Misc/NEWS.d/next/Library/2020-11-27-21-46-54.bpo-41818.IXmYhQ.rst diff --git a/Misc/NEWS.d/next/Library/2020-11-27-21-46-54.bpo-41818.IXmYhQ.rst b/Misc/NEWS.d/next/Library/2020-11-27-21-46-54.bpo-41818.IXmYhQ.rst new file mode 100644 index 00000000000000..d1878c6e1d8844 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2020-11-27-21-46-54.bpo-41818.IXmYhQ.rst @@ -0,0 +1 @@ +Change expectedFailureOnBSD() to expectedFailureIfNotLinux() in test_pty.py because test_master_read() should be expected to fail on every platform that is not Linux; that includes Solaris. \ No newline at end of file