Skip to content

bpo-35134: Remove the Include/code.h header file #32385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2022
Merged

bpo-35134: Remove the Include/code.h header file #32385

merged 2 commits into from
Apr 7, 2022

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Apr 6, 2022 •
edited by bedevere-bot
Loading

Remove the Include/code.h header file. C extensions should only
include the main <Python.h> header file.

Python.h includes directly Include/cpython/code.h instead.

https://bugs.python.org/issue35134

@vstinner vstinner requested review from a team, iritkatriel, markshannon and tiran as code owners April 6, 2022 22:58
@vstinner
Copy link
Member Author

vstinner commented Apr 6, 2022

None of the top 5000 PyPI projects include directly code.h:

$ ./search_pypi_top.py PYPI-2022-01-26-TOP-5000/ '# *include [<"]code.h[">]' -q
PYPI-2022-01-26-TOP-5000/Pygments-2.11.2.tar.gz: Pygments-2.11.2/tests/examplefiles/c/ceval.c: #include "code.h"
PYPI-2022-01-26-TOP-5000/typed_ast-1.5.2.tar.gz: typed_ast-1.5.2/ast27/Include/compile.h: #include "code.h"

Found 2 matching lines in 2 projects
  • Pygments only uses ceval.c has an example: this C file is not built
  • typed_ast ast27/Include/compile.h is only used on Python 2.7

vstinner added 2 commits April 7, 2022 01:27
@vstinner
bpo-35134: Remove the Include/code.h header file
248b4a7 
Remove the Include/code.h header file. C extensions should only
include the main <Python.h> header file.

Python.h includes directly Include/cpython/code.h instead.
@vstinner
Add #ifndef Py_LIMITED_API
f8ec95b
@vstinner vstinner merged commit 85addfb into python:main Apr 7, 2022
@vstinner vstinner deleted the remove_code_h branch April 7, 2022 00:29
tacaswell added a commit to tacaswell/typed_ast that referenced this pull request May 10, 2022
@tacaswell
BLD: do not include now private header files
4b83f9e 
As of python/cpython#32385 the header
code.h is private but directly included into Python.h
@tacaswell tacaswell mentioned this pull request May 10, 2022
Merged
hauntsaninja pushed a commit to python/typed_ast that referenced this pull request May 10, 2022
@tacaswell
Do not include now private code.h (#188)
617620f 
As of python/cpython#32385 the header
code.h is private but directly included into Python.h
@ezio-melotti ezio-melotti mentioned this pull request Nov 14, 2022
Merged
@vstinner vstinner mentioned this pull request Apr 10, 2022
Closed
@ezio-melotti ezio-melotti mentioned this pull request Dec 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran Awaiting requested review from tiran

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot