From 8878a5faad197377110e57ddc49b66f283925126 Mon Sep 17 00:00:00 2001 From: Laurie O Date: Tue, 13 Sep 2022 19:25:39 +1000 Subject: [PATCH 1/6] Add dataclass field default change Include dataclass field default mutability check change introduced in #29867. See [discourse discussion](https://discuss.python.org/t/better-communicate-dataclass-mutable-default-check-change-in-python-3-11) --- Doc/whatsnew/3.11.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Doc/whatsnew/3.11.rst b/Doc/whatsnew/3.11.rst index 0f6490e6a7cbcd..9f825016a90f70 100644 --- a/Doc/whatsnew/3.11.rst +++ b/Doc/whatsnew/3.11.rst @@ -523,6 +523,13 @@ Added non parallel-safe :func:`~contextlib.chdir` context manager to change the current working directory and then restore it on exit. Simple wrapper around :func:`~os.chdir`. (Contributed by Filipe Laíns in :issue:`25625`) +dataclasses +----------- + +* Change field default mutability check, allowing only defaults which can be + hashed instead of all instances of :class:`dict`, :class:`list` and + :class:`set` (Contributed by Eric V. Smith in :gh:`29867`) + datetime -------- From 22c9d246e18cb49c8e199658f1bf735f6f3ee38e Mon Sep 17 00:00:00 2001 From: Laurie O Date: Tue, 13 Sep 2022 19:35:31 +1000 Subject: [PATCH 2/6] Use BPO issue reference --- Doc/whatsnew/3.11.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Doc/whatsnew/3.11.rst b/Doc/whatsnew/3.11.rst index 9f825016a90f70..afd3ed7b9d8235 100644 --- a/Doc/whatsnew/3.11.rst +++ b/Doc/whatsnew/3.11.rst @@ -528,7 +528,7 @@ dataclasses * Change field default mutability check, allowing only defaults which can be hashed instead of all instances of :class:`dict`, :class:`list` and - :class:`set` (Contributed by Eric V. Smith in :gh:`29867`) + :class:`set` (Contributed by Eric V. Smith in :issue:`44674`) datetime -------- From 0e1f73f0c8406329705a65ec020a8b2c6b942db2 Mon Sep 17 00:00:00 2001 From: Laurie O Date: Tue, 13 Sep 2022 20:04:41 +1000 Subject: [PATCH 3/6] Fix formatting --- Doc/whatsnew/3.11.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Doc/whatsnew/3.11.rst b/Doc/whatsnew/3.11.rst index afd3ed7b9d8235..8d4d6449bc474c 100644 --- a/Doc/whatsnew/3.11.rst +++ b/Doc/whatsnew/3.11.rst @@ -527,8 +527,8 @@ dataclasses ----------- * Change field default mutability check, allowing only defaults which can be - hashed instead of all instances of :class:`dict`, :class:`list` and - :class:`set` (Contributed by Eric V. Smith in :issue:`44674`) + hashed instead of all instances of :class:`dict`, :class:`list` and + :class:`set` (Contributed by Eric V. Smith in :issue:`44674`) datetime -------- From a83efcb99dcba121a472728ce044cdd6cef63fa7 Mon Sep 17 00:00:00 2001 From: Laurie O Date: Tue, 13 Sep 2022 20:08:28 +1000 Subject: [PATCH 4/6] Add link to 'hashable' in glossary --- Doc/whatsnew/3.11.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Doc/whatsnew/3.11.rst b/Doc/whatsnew/3.11.rst index 8d4d6449bc474c..1e67804be60150 100644 --- a/Doc/whatsnew/3.11.rst +++ b/Doc/whatsnew/3.11.rst @@ -526,9 +526,9 @@ around :func:`~os.chdir`. (Contributed by Filipe Laíns in :issue:`25625`) dataclasses ----------- -* Change field default mutability check, allowing only defaults which can be - hashed instead of all instances of :class:`dict`, :class:`list` and - :class:`set` (Contributed by Eric V. Smith in :issue:`44674`) +* Change field default mutability check, allowing only defaults which are + :term:`hashable` instead of all instances of :class:`dict`, :class:`list` + and :class:`set` (Contributed by Eric V. Smith in :issue:`44674`) datetime -------- From 016605c15c0505fbd0ac94a43869abea49d89f67 Mon Sep 17 00:00:00 2001 From: Laurie O Date: Tue, 13 Sep 2022 20:22:18 +1000 Subject: [PATCH 5/6] Fix description of prior behaviour --- Doc/whatsnew/3.11.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Doc/whatsnew/3.11.rst b/Doc/whatsnew/3.11.rst index 1e67804be60150..cb073f531975b2 100644 --- a/Doc/whatsnew/3.11.rst +++ b/Doc/whatsnew/3.11.rst @@ -527,8 +527,9 @@ dataclasses ----------- * Change field default mutability check, allowing only defaults which are - :term:`hashable` instead of all instances of :class:`dict`, :class:`list` - and :class:`set` (Contributed by Eric V. Smith in :issue:`44674`) + :term:`hashable` instead of any object which is not an instance of + :class:`dict`, :class:`list` or :class:`set` (Contributed by Eric V. Smith in + :issue:`44674`) datetime -------- From 64114e48dd3ac7f9b3d6834a76c306bb3fc7d6ce Mon Sep 17 00:00:00 2001 From: Laurie O Date: Tue, 13 Sep 2022 20:28:48 +1000 Subject: [PATCH 6/6] Add trailing periods Co-authored-by: Hugo van Kemenade --- Doc/whatsnew/3.11.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Doc/whatsnew/3.11.rst b/Doc/whatsnew/3.11.rst index cb073f531975b2..e3580c5a36fbb4 100644 --- a/Doc/whatsnew/3.11.rst +++ b/Doc/whatsnew/3.11.rst @@ -528,8 +528,8 @@ dataclasses * Change field default mutability check, allowing only defaults which are :term:`hashable` instead of any object which is not an instance of - :class:`dict`, :class:`list` or :class:`set` (Contributed by Eric V. Smith in - :issue:`44674`) + :class:`dict`, :class:`list` or :class:`set`. (Contributed by Eric V. Smith in + :issue:`44674`.) datetime --------