Skip to content

gh-98139: enhance namespace package repr #98870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2022
Merged

gh-98139: enhance namespace package repr #98870

merged 2 commits into from
Nov 6, 2022

Conversation

@iyume
Copy link
Contributor

@iyume iyume commented Oct 30, 2022 •
edited by bedevere-bot
Loading

FFY00
FFY00 approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@FFY00 FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks correct, and from the discussion on the issue, it seems like this is the direction we want to go.

Thank you @iyume!

@FFY00 FFY00 merged commit bd221c0 into python:main Nov 6, 2022
@FFY00 FFY00 mentioned this pull request Nov 6, 2022
Closed
This was referenced Nov 25, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FFY00 FFY00 FFY00 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iyume @FFY00 @bedevere-bot