Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use targeted env vars for macOS build instructions #1057

Closed
erlend-aasland opened this issue Feb 22, 2023 · 0 comments · Fixed by #1058
Closed

Use targeted env vars for macOS build instructions #1057

erlend-aasland opened this issue Feb 22, 2023 · 0 comments · Fixed by #1058

Comments

@erlend-aasland
Copy link
Contributor

Pr. now, we unfortunately encourage setting CFLAGS and LDFLAGS for the scope of the entire build, simply to satisfy the build requirements of the _gdbm and _lzma extension modules.

Following the recent build system improvements, we've now got targeted variables for this, such as GDBM_CFLAGS and GDBM_LIBS. We should use them.

This is a follow-up to #1052 (and various other recent macOS build instruction improvements).
@erlend-aasland erlend-aasland linked a pull request Feb 22, 2023 that will close this issue
Use targeted env vars for overriding compiler/linker args on macOS #1058
Merged
@erlend-aasland erlend-aasland changed the title Improve macOS build instructions Use targeted env vars for macOS build instructions Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use targeted env vars for overriding compiler/linker args on macOS erlend-aasland/devguide
1 participant
@erlend-aasland