From 7ca2308880108438639b2cb723e5780671adc2d6 Mon Sep 17 00:00:00 2001 From: Mariatta Wijaya Date: Sun, 23 Apr 2017 20:33:50 -0700 Subject: [PATCH] Document when a review can be dismissed. Closes https://github.com/python/devguide/issues/161 --- pullrequest.rst | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/pullrequest.rst b/pullrequest.rst index d45c8c1956..e2905878b8 100644 --- a/pullrequest.rst +++ b/pullrequest.rst @@ -323,6 +323,15 @@ code and leave comments in the pull request or issue tracker. 'merge-ready', you should always make sure the entire test suite passes. +Dismissing Review from Another Core Developer +--------------------------------------------- + +A core developer can dismiss another core developer's review if they confirmed +that the requested changes have been made. When a core developer has assigned +the PR to themselves, then it is a sign that they are actively looking after +the PR, and their review should not be dismissed. + + Committing/Rejecting --------------------