Fix narrowing of nested union of TypedDicts #11204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in refine_parent_types() bailed out when it encountered something other than a TypedDict in the union, including a nested union of TypedDicts. This caused the narrowing to fail. Fix it by making it iterate over the flattened union items. Fixes python#9308.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9308.
The code in
refine_parent_types()bailed out when it encounteredsomething other than a TypedDict in the union, including a nested union
of TypedDicts. This caused the narrowing to fail.
Fix it by making it iterate over the flattened union items.
Test Plan
Added a unit test case. It fails before and passes after.