Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 723: Mark as Provisional #3505

Merged
merged 12 commits into from
Nov 3, 2023
Merged

PEP 723: Mark as Provisional #3505

merged 12 commits into from
Nov 3, 2023

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Oct 22, 2023 •
edited by github-actions bot
Loading

@ofek ofek requested a review from AA-Turner as a code owner October 22, 2023 14:44
JelleZijlstra
JelleZijlstra reviewed Oct 22, 2023
View reviewed changes
peps/pep-0723.rst Outdated Show resolved Hide resolved
@hugovk hugovk changed the title PEP 723: Mark as final PEP 723: Mark as accepted Oct 22, 2023
willingc
willingc reviewed Oct 29, 2023
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ofek. I've made a couple of suggestions about wording.

peps/pep-0723.rst Outdated Show resolved Hide resolved
peps/pep-0723.rst Outdated Show resolved Hide resolved
peps/pep-0723.rst Outdated Show resolved Hide resolved
@ofek @willingc
Apply suggestions from code review
4bf2c8a 
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
willingc
willingc approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

brettcannon
brettcannon requested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The acceptance is conditional on changes in pyproject.toml, so the status should reflect that.

peps/pep-0723.rst Outdated Show resolved Hide resolved
@ofek @brettcannon
Apply suggestions from code review
8ccf368 
Co-authored-by: Brett Cannon <brett@python.org>
@hugovk hugovk changed the title PEP 723: Mark as accepted PEP 723: Mark as Provisional Oct 31, 2023
brettcannon
brettcannon reviewed Oct 31, 2023
View reviewed changes
peps/pep-0723.rst Outdated Show resolved Hide resolved
ofek and others added 2 commits October 31, 2023 19:16
@ofek @brettcannon
Apply suggestions from code review
cf4e056 
Co-authored-by: Brett Cannon <brett@python.org>
@ofek
Update pep-0723.rst
40558d8
@brettcannon brettcannon self-assigned this Nov 1, 2023
DavidCEllis
DavidCEllis reviewed Nov 1, 2023
View reviewed changes
peps/pep-0723.rst Outdated Show resolved Hide resolved
ofek and others added 2 commits November 1, 2023 15:58
@ofek @DavidCEllis
Apply suggestions from code review
c0d1547 
Co-authored-by: David Ellis <ducksual@gmail.com>
@ofek
fix spacing
246b133
@brettcannon brettcannon merged commit 04b3abd into python:main Nov 3, 2023
6 checks passed
@brettcannon
Copy link
Member

Thanks, everyone!

@ofek ofek deleted the pep-723 branch November 3, 2023 19:24
@henryiii henryiii mentioned this pull request Nov 3, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidCEllis DavidCEllis DavidCEllis left review comments

@pfmoore pfmoore pfmoore left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@willingc willingc willingc approved these changes

@brettcannon brettcannon brettcannon approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

@brettcannon brettcannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ofek @brettcannon @JelleZijlstra @pfmoore @willingc @DavidCEllis