Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing metaclasses #8497

Merged
merged 9 commits into from
Aug 8, 2022
Merged

Add missing metaclasses #8497

merged 9 commits into from
Aug 8, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Aug 5, 2022

AlexWaygood
AlexWaygood reviewed Aug 5, 2022
View reviewed changes
stdlib/dataclasses.pyi Outdated Show resolved Hide resolved
AlexWaygood
AlexWaygood reviewed Aug 5, 2022
View reviewed changes
stdlib/string.pyi Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood reviewed Aug 5, 2022
View reviewed changes
stdlib/contextlib.pyi Outdated Show resolved Hide resolved
stdlib/contextlib.pyi Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
@sobolevn
Copy link
Member Author

sobolevn commented Aug 5, 2022

Ok, looks like mypy cannot work with TypeAliased metaclasses. I will send a fix shortly.

@sobolevn sobolevn mentioned this pull request Aug 5, 2022
Closed
@sobolevn
Copy link
Member Author

sobolevn commented Aug 5, 2022

This mypy PR should fix that: python/mypy#13335

@github-actions

This comment has been minimized.

Sign in to view
@srittau srittau added the status: deferred Issue or PR deferred until some precondition is fixed label Aug 8, 2022
@srittau
Copy link
Collaborator

srittau commented Aug 8, 2022

I marked this as deferred. As I understand it, we need to wait for the next mypy release to be able to land this.

@AlexWaygood
Copy link
Member

I marked this as deferred. As I understand it, we need to wait for the next mypy release to be able to land this.

We can do the ones in ast.pyi and contextlib.pyi now. @sobolevn, why don't you revert the other changes for now, and we can do them after the next mypy release?

@sobolevn
Copy link
Member Author

sobolevn commented Aug 8, 2022

Done! Good idea 👍

@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@AlexWaygood AlexWaygood removed the status: deferred Issue or PR deferred until some precondition is fixed label Aug 8, 2022
AlexWaygood
AlexWaygood reviewed Aug 8, 2022
View reviewed changes
stdlib/ast.pyi Outdated Show resolved Hide resolved
stdlib/contextlib.pyi Outdated Show resolved Hide resolved
stdlib/contextlib.pyi Outdated Show resolved Hide resolved
sobolevn and others added 3 commits August 8, 2022 17:51
@sobolevn @AlexWaygood
Update stdlib/contextlib.pyi
45591c6 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@sobolevn @AlexWaygood
Update stdlib/ast.pyi
0c2063e 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@sobolevn @AlexWaygood
Update stdlib/contextlib.pyi
7cbde17 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
AlexWaygood approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 4e5d9d1 into python:master Aug 8, 2022
@AlexWaygood
Copy link
Member

@sobolevn, now that mypy works with TypeAlias'd metaclasses, do you want to do a new PR with the dataclasses/string changes?

@sobolevn
Copy link
Member Author

sobolevn commented Oct 5, 2022

Thanks for the reminder :)
Will do in 1 hour.

@sobolevn sobolevn mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @srittau @AlexWaygood