Skip to content

[monarch] don't rotate logs, even daily #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: gh/suo/66/base
Choose a base branch
from
Open

Conversation

suo
Copy link
Contributor

@suo suo commented Jul 18, 2025

Stack from ghstack (oldest at bottom):

this is quite annoying to deal with in the logarithm UI. Let's avoid rotating logs unless we have a proven issue.

Differential Revision: D78531468

NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!

this is quite annoying to deal with in the logarithm UI. Let's avoid rotating logs unless we have a proven issue.

Differential Revision: [D78531468](https://our.internmc.facebook.com/intern/diff/D78531468/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78531468/)!

[ghstack-poisoned]
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 18, 2025
suo added a commit that referenced this pull request Jul 18, 2025
this is quite annoying to deal with in the logarithm UI. Let's avoid rotating logs unless we have a proven issue.

Differential Revision: [D78531468](https://our.internmc.facebook.com/intern/diff/D78531468/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78531468/)!

ghstack-source-id: 296986815
Pull Request resolved: #577
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78531468

this is quite annoying to deal with in the logarithm UI. Let's avoid rotating logs unless we have a proven issue.

Differential Revision: [D78531468](https://our.internmc.facebook.com/intern/diff/D78531468/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78531468/)!

[ghstack-poisoned]
suo added a commit that referenced this pull request Jul 18, 2025
Pull Request resolved: #577

this is quite annoying to deal with in the logarithm UI. Let's avoid rotating logs unless we have a proven issue.
ghstack-source-id: 296989648
@exported-using-ghexport

Differential Revision: [D78531468](https://our.internmc.facebook.com/intern/diff/D78531468/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78531468/)!
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78531468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants