Generalize Model Size Code #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: previously this worked only on model swap quantized classes and the version in generate.py was specific to a few cases, this new version is significantly more general and now consolidated into a single place. Test Plan: python test_integration.py -k "test_get_model_size" Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/364
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 14cec96 with merge base 8841094 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
msaroufim
approved these changes
Jun 14, 2024
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
supriyar
pushed a commit
that referenced
this pull request
Jun 14, 2024
* Generalize Model Size Code Summary: previously this worked only on model swap quantized classes and the version in generate.py was specific to a few cases, this new version is significantly more general and now consolidated into a single place. Test Plan: python test_integration.py -k "test_get_model_size" Reviewers: Subscribers: Tasks: Tags: * fix test failures Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
NicoleMayer
pushed a commit
that referenced
this pull request
Jul 9, 2024
* Generalize Model Size Code Summary: previously this worked only on model swap quantized classes and the version in generate.py was specific to a few cases, this new version is significantly more general and now consolidated into a single place. Test Plan: python test_integration.py -k "test_get_model_size" Reviewers: Subscribers: Tasks: Tags: * fix test failures Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
* Generalize Model Size Code Summary: previously this worked only on model swap quantized classes and the version in generate.py was specific to a few cases, this new version is significantly more general and now consolidated into a single place. Test Plan: python test_integration.py -k "test_get_model_size" Reviewers: Subscribers: Tasks: Tags: * fix test failures Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: previously this worked only on model swap quantized classes and the version in generate.py was specific to a few cases, this new version is significantly more general and now consolidated into a single place.
Test Plan: python test_integration.py -k "test_get_model_size"
Reviewers:
Subscribers:
Tasks:
Tags: