Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

073 scripts for benchmarks #372

Merged
merged 3 commits into from
Jun 18, 2024
Merged

073 scripts for benchmarks #372

merged 3 commits into from
Jun 18, 2024

Conversation

HDCharles
Copy link
Contributor

Instructions for downloading model weights

Summary:

Added instructions for downloading model weights, and model weight
download scripts.

Test Plan:

huggingface-cli login
sh ./scripts/prepare.sh

Reviewers:

Subscribers:

Tasks:

Tags:

Summary:

Added instructions for downloading model weights, and model weight
download scripts.

Test Plan:

huggingface-cli login
sh ./scripts/prepare.sh

Reviewers:

Subscribers:

Tasks:

Tags:
Summary:

Test Plan:

sh benchmarks.sh

Reviewers:

Subscribers:

Tasks:

Tags:
Copy link

pytorch-bot bot commented Jun 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/372

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f0de569 with merge base bc2f8b7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 15, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice if the model name could be passed as a command line parameter because then I can selectively download one at a time, but also it is just two commands so its not really a big deal either way

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use the download.py script to do that, prepare is supposed to be setup to directly handle the things we advertise as our benchmarks

@HDCharles HDCharles merged commit 00e1546 into main Jun 18, 2024
13 checks passed
@vayuda vayuda deleted the 073_scripts_for_benchmarks branch June 18, 2024 17:49
dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
* Instructions for downloading model weights

Summary:

Added instructions for downloading model weights, and model weight
download scripts.

Test Plan:

huggingface-cli login
sh ./scripts/prepare.sh

Reviewers:

Subscribers:

Tasks:

Tags:

* updating paths to model checkpoint dir

Summary:

Test Plan:

sh benchmarks.sh

Reviewers:

Subscribers:

Tasks:

Tags:

* added checkpoints folder to git ignore

---------

Co-authored-by: vayuda <120random.things@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants