Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New README #392

Merged
merged 20 commits into from
Jun 19, 2024
Merged

New README #392

merged 20 commits into from
Jun 19, 2024

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Jun 18, 2024

This a restructuring of our main README.md with the main goals of having

  1. Clearer focus on our training, inference finetuning story
  2. Clarifying our quantization terminology
  3. Clearer benchmarks and API usage

Copy link

pytorch-bot bot commented Jun 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/392

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 7464e55 with merge base aeee551 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 18, 2024
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated

### Training

We've added support for semi-structured 2:4 sparsity with over 30% speedups on ViT-L
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to clarify, the speedup here is not for the entire model. I believe its specifically for the MLP blocks in ViT. cc @jcaip

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we put together anything from an end to end perspective

README.md Outdated

For VIT-L MLP shapes on a NVIDIA A100 we see the following results:

| | act24 | dense | w24 | s24_inp_sparsify24 | s24_inp_clone |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed this with @jcaip offline but would be good to make the columns here more clear.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcaip please send me a clearer table when you have it - keep in mind I want to make some claim about end to end performance

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm making some changes to the benchmarking script for e2e ViT. Will send something by EOD.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Contributor

@supriyar supriyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 🚀

Ready to ship once we add the latest sparsity numbers.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@msaroufim msaroufim merged commit 0304281 into main Jun 19, 2024
12 of 13 checks passed
@msaroufim msaroufim deleted the msaroufim/newread branch June 19, 2024 02:14
@msaroufim msaroufim mentioned this pull request Jun 19, 2024
dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
* New README

* yolo

* yolo

* Update README.md

* Update README.md

* Trigger CI

* Trigger CI

* Trigger CI

* push

* push

* push

* push

* push

* push

* push

* push

* push

* push

* push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants