Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users are running
This is causing a force downgrade to
torch==2.3.1
Instead we should tell users that if they want CPP extensions working with an official release they should install
torch==2.3.1
in documentation but we should never force downgradeSo with this PR we remove the pytorch dependency completely and instead rely on building
torchao
without build isolation to make suretorch
is available as a build time dependencyThis is an unfortunate workaround because
pyproject.toml
is not expressive enough to pick a dynamic version fortorch
Todo: figure out the right test strategy for this PR