Update low-bit Adam benchmark #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gau-nernst
commented
Jul 6, 2024
gau-nernst
commented
- Benchmark script: (1) Add ability to set random seed, so it's easier to compare implementation's correctness. (2) Add lpmm 4-bit Adam with rank-1 normalization option
- Benchmark results: Update results without compile time. Add results for lpmm 4-bit Adam with rank-1 normalization.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/481
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8fc9ba2 with merge base 34fedff ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
msaroufim
approved these changes
Jul 6, 2024
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
* update benchmark * add rank1 option to lpmm * add comma * update readme * remove unwanted file * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.