Add CUDA compute capability compile guard #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/636
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2f0aef4 with merge base e11201a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
gau-nernst
commented
Aug 8, 2024
| @@ -14,6 +14,8 @@ | |||
| // | |||
| // This file is adapted from https://github.com/usyd-fsalab/fp6_llm/blob/5df6737cca32f604e957e3f63f03ccc2e4d1df0d/fp6_llm/csrc/fp6_linear.cu | |||
|
|
|||
| #if !defined(__CUDA_ARCH__) || __CUDA_ARCH__ >= 800 // at least Ampere | |||
There was a problem hiding this comment.
For anyone wondering why this instead of defined(__CUDA_ARCH__) && __CUDA_ARCH__ >= 800, I'm following this.
One reason I can think of is for vscode intellisense to work. If I use #if defined(__CUDA_ARCH__), vscode will not do syntax highlighting. There are workarounds, like this, but it is more cumbersome.
msaroufim
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #632
Tested on Google Colab