Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add layout option to woq int4 api (#670)" #678

Closed
wants to merge 1 commit into from

Conversation

msaroufim
Copy link
Member

This reverts commit 009f55f.

Copy link

pytorch-bot bot commented Aug 14, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/678

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (7 Unrelated Failures)

As of commit 8b7b538 with merge base 009f55f (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2024
@msaroufim msaroufim closed this Aug 14, 2024
@Diogo-V
Copy link
Contributor

Diogo-V commented Aug 14, 2024

@msaroufim - Just saw that you had to revert this commit. Is there anything that I can do to help?

@msaroufim
Copy link
Member Author

Thanks for checking @Diogo-V - the breakage I saw wasn't due to your PR, the breakage just happened to be observed when your PR was merged to main

So all g! But again really appreciate you checking!

@Diogo-V
Copy link
Contributor

Diogo-V commented Aug 14, 2024

Of course! I usually follow my PRs to prod until I know that everything is fine and working :)

If there was any way that I could have spotted it, let me know and I will be sure to check it next time! As of now, the only way that I test the code is by running the command pytest test/ which I don't know if it covers everything.

@Diogo-V
Copy link
Contributor

Diogo-V commented Aug 14, 2024

Regarding #670, do you want me to open it again and/or make any modifications to it?

@msaroufim
Copy link
Member Author

Nope no action needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants