Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Refactor quant_llm to work with affine quantized tensor" #767

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

jerryzh168
Copy link
Contributor

Reverts #696

Copy link

pytorch-bot bot commented Aug 28, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/767

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2add1b5 with merge base 0fed444 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2024
@jerryzh168
Copy link
Contributor Author

looks like it breaks CI, it has an error that does not appear in the PR CI: https://github.com/pytorch/ao/actions/runs/10588415262/job/29340895949

@msaroufim msaroufim merged commit da8c5b9 into main Aug 28, 2024
15 checks passed
@msaroufim msaroufim deleted the revert-696-refactor-quant-llm branch August 28, 2024 01:45
@gau-nernst
Copy link
Collaborator

I think it might have to do with importing C++ extension. Depending on the import order, it might not get imported

from . import _C

Maybe that line should be inside ops.py? Or some kind of guards to prevent undefined ops because they are defined in C++?

@jerryzh168
Copy link
Contributor Author

yeah let me test putting this in ops.py first, that sounds like a reasonable fix, although historically we have been struggling with this import..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants