fixup! Tweak TempDirMixin

Author: mthrok

test/sox_io_backend/sox_utils.py

@@ -31,7 +31,12 @@ def gen_audio_file(
             'Use get_wav_data and save_wav to generate wav file for accurate result.')
     command = [
         'sox',
-        '-V',  # verbose
+        '-V3',  # verbose
+        '-R',
+        # -R is supposed to be repeatable, though the implementation looks suspicious
+        # and not setting the seed to a fixed value.
+        # https://fossies.org/dox/sox-14.4.2/sox_8c_source.html
+        # search "sox_globals.repeatable"
     ]
     if bit_depth is not None:
         command += ['--bits', str(bit_depth)]
@@ -64,7 +69,7 @@ def convert_audio_file(
         src_path, dst_path,
         *, bit_depth=None, compression=None):
     """Convert audio file with `sox` command."""
-    command = ['sox', '-V', str(src_path)]
+    command = ['sox', '-V3', '-R', str(src_path)]
     if bit_depth is not None:
         command += ['--bits', str(bit_depth)]
     if compression is not None:

test/sox_io_backend/test_info.py

@@ -44,7 +44,7 @@ def test_wav(self, dtype, sample_rate, num_channels):
     def test_wav_multiple_channels(self, dtype, sample_rate, num_channels):
         """`sox_io_backend.info` can check wav file with channels more than 2 correctly"""
         duration = 1
-        path = self.get_temp_path(f'data.wav')
+        path = self.get_temp_path('data.wav')
         data = get_wav_data(dtype, num_channels, normalize=False, num_frames=duration * sample_rate)
         save_wav(path, data, sample_rate)
         info = sox_io_backend.info(path)
@@ -60,7 +60,7 @@ def test_wav_multiple_channels(self, dtype, sample_rate, num_channels):
     def test_mp3(self, sample_rate, num_channels, bit_rate):
         """`sox_io_backend.info` can check mp3 file correctly"""
         duration = 1
-        path = self.get_temp_path(f'data.mp3')
+        path = self.get_temp_path('data.mp3')
         sox_utils.gen_audio_file(
             path, sample_rate, num_channels,
             compression=bit_rate, duration=duration,
@@ -79,7 +79,7 @@ def test_mp3(self, sample_rate, num_channels, bit_rate):
     def test_flac(self, sample_rate, num_channels, compression_level):
         """`sox_io_backend.info` can check flac file correctly"""
         duration = 1
-        path = self.get_temp_path(f'data.flac')
+        path = self.get_temp_path('data.flac')
         sox_utils.gen_audio_file(
             path, sample_rate, num_channels,
             compression=compression_level, duration=duration,
@@ -97,7 +97,7 @@ def test_flac(self, sample_rate, num_channels, compression_level):
     def test_vorbis(self, sample_rate, num_channels, quality_level):
         """`sox_io_backend.info` can check vorbis file correctly"""
         duration = 1
-        path = self.get_temp_path(f'data.vorbis')
+        path = self.get_temp_path('data.vorbis')
         sox_utils.gen_audio_file(
             path, sample_rate, num_channels,
             compression=quality_level, duration=duration,

test/sox_io_backend/test_load.py

@@ -24,7 +24,7 @@ def assert_wav(self, dtype, sample_rate, num_channels, normalize, duration):
 
         Wav data loaded with sox_io backend should match those with scipy
         """
-        path = self.get_temp_path(f'reference.wav')
+        path = self.get_temp_path('reference.wav')
         data = get_wav_data(dtype, num_channels, normalize=normalize, num_frames=duration * sample_rate)
         save_wav(path, data, sample_rate)
         expected = load_wav(path, normalize=normalize)[0]

test/sox_io_backend/test_roundtrip.py

@@ -23,16 +23,15 @@ class TestRoundTripIO(TempDirMixin, PytorchTestCase):
         ['float32', 'int32', 'int16', 'uint8'],
         [8000, 16000],
         [1, 2],
-        [False, True]
     )), name_func=get_test_name)
-    def test_roundtrip_wav(self, dtype, sample_rate, num_channels, normalize):
+    def test_wav(self, dtype, sample_rate, num_channels):
         """save/load round trip should not degrade data for wav formats"""
-        original = get_wav_data(dtype, num_channels, normalize=normalize)
+        original = get_wav_data(dtype, num_channels, normalize=False)
         data = original
         for i in range(10):
             path = self.get_temp_path(f'{i}.wav')
             sox_io_backend.save(path, data, sample_rate)
-            data, sr = sox_io_backend.load(path, normalize=normalize)
+            data, sr = sox_io_backend.load(path, normalize=False)
             assert sr == sample_rate
             self.assertEqual(original, data)
 
@@ -41,7 +40,7 @@ def test_roundtrip_wav(self, dtype, sample_rate, num_channels, normalize):
         [1, 2],
         list(range(9)),
     )), name_func=get_test_name)
-    def test_roundtrip_flac(self, sample_rate, num_channels, compression_level):
+    def test_flac(self, sample_rate, num_channels, compression_level):
         """save/load round trip should not degrade data for flac formats"""
         original = get_wav_data('float32', num_channels)
         data = original

test/sox_io_backend/test_save.py

@@ -24,7 +24,8 @@ def assert_wav(self, dtype, sample_rate, num_channels, num_frames):
         path = self.get_temp_path('data.wav')
         expected = get_wav_data(dtype, num_channels, num_frames=num_frames)
         sox_io_backend.save(path, expected, sample_rate)
-        found = load_wav(path)[0]
+        found, sr = load_wav(path)[0]
+        assert sample_rate == sr
         self.assertEqual(found, expected)
 
     def assert_mp3(self, sample_rate, num_channels, bit_rate, duration):